Minor refractors to improve DX

[emma31-dev]

I had made a few code refractors that doesn't much affect the working of Navi. I did the following:

• In git.rs: i added better support for other git providers and error message on invalid link. i also added more test cases
• In clipboard.rs: i changed module import from importing the whole prelude.rs to just anyhow::Result that is being used
• In fs.rs: i implemented modern practices by importing just the used fuctions and not the whole std::fs(not that important)

TY :)

[welcome]

Thanks for opening this pull request!

[alexis-opolka]

Hi @emma31-dev ,
Thanks! I'll take a look at it when I have some free time during the week. ^-^

[emma31-dev]

Yoo
Another hing ...
are you guys planning of updating the depencies and rustc to the stable 2024 version. @alexis-opolka and @denisidoro

[alexis-opolka]

LGTM

[alexis-opolka]

Yoo Another hing ... are you guys planning of updating the depencies and rustc to the stable 2024 version.

I think we could, I haven't yet looked into it. Would you need something out of the new features of the 2024 version?
I'll look into it in the following weeks, I'll have a bit more free time to give to navi.

And sorry for the wait, once again. ^^

[alexis-opolka]

Could you please look into the failing test? @emma31-dev

I'll merge the PR once the test passes.

[emma31-dev]

Ok I'll look into it today

[emma31-dev]

OMG
lemme see if i can tackle all today

[alexis-opolka]

That seems ok to me, that specific bash test fails since months.

Would you like me to merge it now?

[emma31-dev]

That seems ok to me, that specific bash test fails since months.

Would you like me to merge it now?

yeah merge it. i was thinking of adding more test cases later thou 😁

[alexis-opolka]

I'm always for adding tests, don't hesitate to spin up a PR later on if you'd like. ^-^