fix: prevent panic on multi-byte UTF-8 in cheatsheet prefix lines#1025
Open
kimjune01 wants to merge 1 commit into
Open
fix: prevent panic on multi-byte UTF-8 in cheatsheet prefix lines#1025kimjune01 wants to merge 1 commit into
kimjune01 wants to merge 1 commit into
Conversation
without_prefix used byte-indexing (line[2..]) which panics when the
separator after #/%/@ is a multi-byte character like non-breaking
space (\u{a0}). Skip only the 1-byte ASCII prefix and let trim()
handle all whitespace variants.
Also fix dormant panic in without_first for multi-byte first chars.
Closes denisidoro#917
|
您好！您的邮件我已收到，我会尽快的查阅邮件。谢谢您的来信！
|
denisidoro
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #917.
without_prefixassumed the prefix character plus separator always occupies exactly 2 bytes (line[2..]). When the separator is a non-breaking space (\u{a0}, 2 bytes in UTF-8), byte index 2 falls inside the multi-byte character and panics:Skip only the 1-byte ASCII prefix char (
#,%,@) and lettrim()handle any whitespace separator, including multi-byte whitespace. Same idea applied towithout_first.Tests cover the exact input from the bug report, normal ASCII prefixes, and edge cases (empty, prefix-only).