Open
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for rendering Button with variant="tag" at the smaller Tag size, aligning Button’s tag variant behavior with the existing Tag component sizing API (Issue #1957).
Changes:
- Added a
sizeprop toButtonandTagButtonand appliedTag--smallstyling whenvariant="tag"andsize="small". - Added unit tests covering
size="small"for bothButton(tag variant) andTagButton. - Added Playwright component screenshot coverage and committed new baseline images for small tag buttons (light/dark).
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/components/TagButton/index.tsx | Plumbs size through TagButton into Button. |
| packages/react/src/components/TagButton/index.test.tsx | Adds a unit test asserting Tag--small is applied. |
| packages/react/src/components/Button/index.tsx | Introduces size prop and toggles Tag--small class for tag variant. |
| packages/react/src/components/Button/index.test.tsx | Adds unit test for small tag button class behavior. |
| packages/react/src/components/Button/screenshots.e2e.tsx | Adds screenshot test for variant="tag" + size="small" states (light/dark). |
| e2e/screenshots/button-variant-tag-size-small-.png | New baseline screenshot (light theme). |
| e2e/screenshots/dark--button-variant-tag-size-small-.png | New baseline screenshot (dark theme). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chornonoh-vova
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1957