Fix missing comma in emoji.txt between and 🎻#298
Open
festeh wants to merge 1 commit intodesktop-app:masterfrom
Open
Fix missing comma in emoji.txt between and 🎻#298festeh wants to merge 1 commit intodesktop-app:masterfrom
festeh wants to merge 1 commit intodesktop-app:masterfrom
Conversation
Section 1's replacement for the activities category was missing a comma
between the (harp) and 🎻 (violin) entries:
"🪕","""🎻","🪈"
ReadString in codegen/codegen/emoji/data_read.cpp tolerates this by
taking only the first quoted token per comma-separated chunk, so 🎻 is
silently dropped from the activities part. The emoji is still picked up
from the "other" section at the end of the file, but that means it
ends up in a different sprite/cell from where the picker entry suggests.
Restore the comma so 🎻 is kept in the activities replacement.
|
|
festeh
added a commit
to festeh/telega2
that referenced
this pull request
Apr 25, 2026
Replace the per-PNG emoji bundle (3700 files, 37 MB) with the 8 WEBP atlases vendored from desktop-app/lib_ui. A new build-time codegen parses emoji.txt and emits emoji_catalog.g.dart — a const map from the canonical (FE0F-stripped) emoji string to a (sprite, row, col) tile. TelegramEmojiWidget paints the tile via canvas.drawImageRect, so a chat-load no longer touches disk for emoji rendering. The tokenizer in emoji_utils now greedy-matches against the catalog, so ZWJ family sequences and skin-toned hands resolve as a single tile instead of splitting into pieces. Catalog misses and atlas decode failures are surfaced through AppLogger so silent-render bugs don't recur. The codegen mirrors lib_ui/codegen's strict ReadString — it takes only the first quoted token per comma-separated chunk, which silently drops the second value when emoji.txt has a missing-comma typo (currently ""🎻 in the activities replacement). This keeps our atlas indexing aligned with the shipped WEBPs even before the upstream typo is fixed (PR opened at desktop-app/lib_ui#298). Bundle size: 37 MB → 8.8 MB. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emoji.txtline 696 (the section-1 replacement for the activities category) is missing a comma between the harp and the violin 🎻 entries:Fix
Add the missing comma.