test: add experiment list test for stop row action#10059
Open
ashtonG wants to merge 2 commits into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10059 +/- ##
==========================================
- Coverage 54.28% 50.78% -3.50%
==========================================
Files 1259 953 -306
Lines 157285 130301 -26984
Branches 3643 3643
==========================================
- Hits 85384 66179 -19205
+ Misses 71768 63989 -7779
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ashtonG
requested review from
a team,
jesse-amano-hpe and
julian-determined-ai
and removed request for
julian-determined-ai
jesse-amano-hpe
approved these changes
Oct 28, 2024
This adds an experiment list test for the stop action. it also introduces a new test fixture to allow for creating new experiments to be cleaned up afterwards on the fly.
ashtonG
force-pushed
the
test/ET-661/test-actions-stop
branch
from
a8058c4 to
c453c34
Compare
ashtonG
commented
Oct 30, 2024
| metric: 'x', | ||
| name: 'custom', | ||
| unit: 'batches', | ||
| name: 'random', |
Contributor
Author
There was a problem hiding this comment.
we got rid of the custom searcher last week.
JComins000
reviewed
Oct 30, 2024
| await row.experimentActionDropdown.open(); | ||
| await expect(row.experimentActionDropdown.pwLocator).toBeVisible(); | ||
| await expect( | ||
| row.experimentActionDropdown.pwLocator.getByRole('menuitem', { name: 'Stop' }), |
Contributor
There was a problem hiding this comment.
i prefer experimentActionDropdown.menuItem but i'm happy as long as it works
JComins000
approved these changes
Oct 30, 2024
thiagodallacqua-hpe
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
ET-661
Description
This adds an experiment list test for the stop action. it also introduces a new test fixture to allow for creating new experiments to be cleaned up afterwards on the fly.
Test Plan
Tests should pass
Checklist
docs/release-notes/See Release Note for details.