Skip to content

Add about dialog component#26

Merged
wrynearson merged 4 commits into
mainfrom
feat/about-dialog-box
Sep 1, 2025
Merged

Add about dialog component#26
wrynearson merged 4 commits into
mainfrom
feat/about-dialog-box

Conversation

@wrynearson

@wrynearson wrynearson commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

Closes #24

This PR adds an About menu item. On click, it opens as dialog component explaining the product, and provides an info/disclaimer about limitation. On small screens, the dialog component can scroll.

image image

@wrynearson wrynearson requested a review from gadomski August 29, 2025 12:57
@wrynearson wrynearson marked this pull request as ready for review August 29, 2025 12:57
@wrynearson wrynearson changed the title add about dialog box, opened in header menu Add about dialog component Aug 29, 2025
@wrynearson

Copy link
Copy Markdown
Collaborator Author

Not sure how to manage version bumps with PRs directly to main -> @gadomski do you have any ideas of best practices?

@wrynearson wrynearson requested a review from zacdezgeo August 29, 2025 13:37
@gadomski

Copy link
Copy Markdown
Contributor

Not sure how to manage version bumps with PRs directly to main -> @gadomski do you have any ideas of best practices?

Do you mean bumping our dependencies, or bumping the version of our app? In the second case, don't think it matters?

@wrynearson

Copy link
Copy Markdown
Collaborator Author

Bumping the version of the app. OK, sounds good if it doesn't matter 😄. On other projects, we've bumped the version every time develop is merged into main, but since we don't have a staging environment for this project, we can arbitrarily bump the version of the app after one or several PRs are merged into main.

@wrynearson wrynearson merged commit 9a9f473 into main Sep 1, 2025
1 check passed
@wrynearson wrynearson deleted the feat/about-dialog-box branch September 1, 2025 06:32
@gadomski

gadomski commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

On other projects, we've bumped the version every time develop is merged into main, but since we don't have a staging environment for this project, we can arbitrarily bump the version of the app after one or several PRs are merged into main.

Yeah, that's about where I'm at for a simple app like this ... versions are primarily a way to communicate with our users, and since our userbase is presumably pretty low, versions aren't worth more than a cursory effort IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add about information

3 participants