Update packages#222
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s Node/tooling baseline and front-end build dependencies/configuration as part of ongoing maintenance for the Tredu theme.
Changes:
- Bumped Node version (
.nvmrc) and updated numerous npm dependencies (incl. webpack 5, ESLint tooling, SVGO). - Modernized
webpack.config.jsby migrating fromeslint-loader/file-loadertoeslint-webpack-pluginand webpack 5 asset modules. - Minor JS bug fix in
Toggleduration handling and small CI cache action update.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
webpack.mix.js |
Removes laravel-mix-eslint-config require (but Mix linting config remains). |
webpack.config.js |
Replaces deprecated loaders with webpack 5 equivalents; adds ESLint plugin; updates SVGO plugin config; adds resolve.fallback. |
package.json |
Updates/bump dependencies (Node/webpack/ESLint/SVGO/etc.) and adds missing runtime dep (hyphenopoly). |
CHANGELOG.MD |
Notes dependency/tooling updates in Unreleased. |
assets/scripts/toggle.js |
Fixes incorrect typeof comparison for duration data attribute. |
.nvmrc |
Updates Node version from v14 to v18.20.4. |
.github/workflows/phpcs-check.yml |
Updates GitHub Actions cache action to v4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "laravel-mix": "^6.0.49", | ||
| "laravel-mix-eslint": "^0.2.0", | ||
| "laravel-mix-eslint-config": "^0.1.7", | ||
| "laravel-mix-svg-sprite": "^2.0.0", |
There was a problem hiding this comment.
@copilot Is there a problem with this if the mix builds are not used?
There was a problem hiding this comment.
If Mix builds are truly never used (not in CI, releases, or local workflow), then this is not a runtime blocker for the current webpack build path. But it is still a maintenance risk: those npm scripts are currently broken (npm run dev-mix fails in this branch), so anyone invoking them later will hit errors. We can either remove the unused Mix path cleanly or keep it updated so it stays runnable.
| "svg-sprite-loader": "^6.0.11", | ||
| "svgo": "^1.3.2", | ||
| "svgo-loader": "^2.2.2" | ||
| "svgo": "^3.3.2", | ||
| "svgo-loader": "^3.0.3", |
| "eslint-webpack-plugin": "^4.2.0", | ||
| "file-loader": "^6.2.0", | ||
| "image-webpack-loader": "^6.0.0", | ||
| "image-webpack-loader": "^8.1.0", |
Project: Tampereen kaupunki, konsernihallinto / Tietohallintoyksikkö:
Project task: Tampere multisite support
Task: https://hiondigital.atlassian.net/browse/TMS-1025
Task title: Projektin ylläpito