Skip to content

Update packages#222

Open
eebbi wants to merge 2 commits into
masterfrom
update-packages-04-2026
Open

Update packages#222
eebbi wants to merge 2 commits into
masterfrom
update-packages-04-2026

Conversation

@eebbi

@eebbi eebbi commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Project: Tampereen kaupunki, konsernihallinto / Tietohallintoyksikkö:
Project task: Tampere multisite support

Task: https://hiondigital.atlassian.net/browse/TMS-1025
Task title: Projektin ylläpito

@eebbi eebbi changed the title Update packages 04 2026 Update packages Jun 2, 2026
@eebbi eebbi requested a review from Copilot June 9, 2026 09:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s Node/tooling baseline and front-end build dependencies/configuration as part of ongoing maintenance for the Tredu theme.

Changes:

  • Bumped Node version (.nvmrc) and updated numerous npm dependencies (incl. webpack 5, ESLint tooling, SVGO).
  • Modernized webpack.config.js by migrating from eslint-loader/file-loader to eslint-webpack-plugin and webpack 5 asset modules.
  • Minor JS bug fix in Toggle duration handling and small CI cache action update.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
webpack.mix.js Removes laravel-mix-eslint-config require (but Mix linting config remains).
webpack.config.js Replaces deprecated loaders with webpack 5 equivalents; adds ESLint plugin; updates SVGO plugin config; adds resolve.fallback.
package.json Updates/bump dependencies (Node/webpack/ESLint/SVGO/etc.) and adds missing runtime dep (hyphenopoly).
CHANGELOG.MD Notes dependency/tooling updates in Unreleased.
assets/scripts/toggle.js Fixes incorrect typeof comparison for duration data attribute.
.nvmrc Updates Node version from v14 to v18.20.4.
.github/workflows/phpcs-check.yml Updates GitHub Actions cache action to v4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines 44 to 46
"laravel-mix": "^6.0.49",
"laravel-mix-eslint": "^0.2.0",
"laravel-mix-eslint-config": "^0.1.7",
"laravel-mix-svg-sprite": "^2.0.0",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Is there a problem with this if the mix builds are not used?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Mix builds are truly never used (not in CI, releases, or local workflow), then this is not a runtime blocker for the current webpack build path. But it is still a maintenance risk: those npm scripts are currently broken (npm run dev-mix fails in this branch), so anyone invoking them later will hit errors. We can either remove the unused Mix path cleanly or keep it updated so it stays runnable.

Comment thread package.json
Comment on lines 56 to +58
"svg-sprite-loader": "^6.0.11",
"svgo": "^1.3.2",
"svgo-loader": "^2.2.2"
"svgo": "^3.3.2",
"svgo-loader": "^3.0.3",
Comment thread package.json
Comment on lines +41 to +43
"eslint-webpack-plugin": "^4.2.0",
"file-loader": "^6.2.0",
"image-webpack-loader": "^6.0.0",
"image-webpack-loader": "^8.1.0",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants