Open
Conversation
devmentor-pl
approved these changes
Aug 7, 2025
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Sandro,
Całość prezentuje się jak należy! 👍
Zostawiłem parę drobnych uwag w komentarzach :)
PS. Menu to nie jest trywialna sprawa - ale teraz już będzie dużo łatwiej :)
| border-bottom-color: transparent; | ||
| border-bottom-color: transparent; | ||
| shape-outside: polygon(0 0, 0% 100%, 100% 0); | ||
| margin-right: 1rem; |
| referrerpolicy="strict-origin-when-cross-origin" | ||
| allowfullscreen> | ||
| </iframe> | ||
| </aside> |
| padding: 2rem; | ||
| margin: 1rem; | ||
| } | ||
|
|
| <li> | ||
| <a href="#">kontakt</a> | ||
| <li class="menu-item"> | ||
| <a href="#">KONTAKT</a> |
| display: flex; | ||
| } | ||
|
|
||
| } No newline at end of file |
|
|
||
| } | ||
|
|
||
| } No newline at end of file |
|
|
||
|
|
||
| <section class="section-double"> | ||
| <div class="section-double--item">.</div> |
Owner
There was a problem hiding this comment.
Jeśli elemet nadrzędny to section-double (czyli Block) to dzieci powinny zawierać nazwę jako Element czyli section-double__item, a nie Modyfikator. Proponuję jeszcze doczytać: https://devmentor.pl/b/metodologia-bem-w-css-i-sass
| width: 33vw; | ||
| background-color: lavenderblush; | ||
| } | ||
| } No newline at end of file |
| box-sizing: border-box; | ||
| } | ||
|
|
||
| header { |
Owner
There was a problem hiding this comment.
Warto stosować resete.css, a potem stylować już tylko po klasach. Przy dużych projektach na prawdę to dużo uprasza :)
| grid-row: 1; | ||
| } | ||
|
|
||
| .b { |
Owner
There was a problem hiding this comment.
UWaga na kolejność elementów przy szerszym ekranie (patrz readme.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spory problem miałam z wypozycjonowaniem poziomego menu z hamburgerem. Menu ciągle uciekało mi na dół, ale w końcu jakoś to ogarnęłam. Trwało to jakieś 50% czasu z czasu spędzonego nad tymi zadaniami :D