Open
Conversation
devmentor-pl
approved these changes
Aug 14, 2025
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Sandro,
Zadania są ok 👍
Zostawiłem w komentarzach parę drobnych uwag ;)
| console.log("Pierwszy użytkownik:", users[0]); | ||
| console.log("Trzeci użytkownik:", users[2]); | ||
| console.log("Piąty użytkownik:", users[4]); | ||
| console.log("Liczba elementów tablicy:", users.length); No newline at end of file |
|
|
||
|
|
||
|
|
||
| for(i = 0; i<randomArray.length; i++) { |
Owner
There was a problem hiding this comment.
Uwaga na deklarację (let) zmiennej. Jeśli nie podamy tego słowa kluczowego przed i to staje się ona globalna, czego nie chcemy.
| oddNumbers.push(allNumbers[j]); | ||
| } | ||
| } | ||
| console.log(oddNumbers); |
Owner
There was a problem hiding this comment.
Tutaj raczej powinniśmy użyć return, aby zwrócić dane. TO pozwoli na elastycznosć takiej funkcji. W obecnym kształcie raczej jej nigdzie nie wykorzystamy :P
| } | ||
|
|
||
| const onlyOddNumbers = function(n) { | ||
| const allNumbers = fullArray(n); |
Owner
There was a problem hiding this comment.
Zastanowiłbym się czy jest sens tworzenia całej tablicy, aby potem utworzyć nową.
Nie lepiej od razu w pętli poniżej uzupełniać tablicę odpowiednimi danymi?
Z punktu wydajności to rozwiązanie będzie lepsze ;)
|
|
||
| function myFunction(num) { | ||
| return 2025 - num; | ||
| } |
|
|
||
| const shorterNotation = numbers.filter(num => num % 2 === 0).reduce((total, num) => total + num, 0); | ||
|
|
||
| console.log("Nie ma to jak funkcje strzałkowe:", shorterNotation); No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.