Conversation
…ties Prior to this change when Charlson comorbidities were requested and id.vars was NULL and age.var was not NULL then there would be an error as the merge to add the age scores onto the results. When there was more than one age value for a unique id.var, the return will have more than one row for the id.var. This is conceptually bad. This change adds to tests/test-comorbidites.R to check for warning messages and expected returns when the id.vars are not one-to-one with c(id.vars, age.var) These changes make sure the error does not occur. Warnings are thrown when there is more than one age for the id.vars fix #43
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 96.54% 96.57% +0.02%
==========================================
Files 17 17
Lines 1304 1314 +10
==========================================
+ Hits 1259 1269 +10
Misses 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change when Charlson comorbidities were requested and id.vars was NULL and age.var was not NULL then there would be an error as the merge to add the age scores onto the results. When there was more than one age value for a unique id.var, the return will have more than one row for the id.var. This is conceptually bad.
This change adds to tests/test-comorbidites.R to check for warning messages and expected returns when the id.vars are not one-to-one with c(id.vars, age.var) These changes make sure the error does not occur. Warnings are thrown when there is more than one age for the id.vars
fix #43