Skip to content

fix(dre): parse plaintext output for blessed replica versions #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pietrodimarco-dfinity wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(dre): parse plaintext output for blessed replica versions #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions shared/dfinity/dre.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,17 @@ def get_cloud_engine_subnet_ids(self) -> list[rollout_types.SubnetId]:
]

def get_blessed_replica_versions(self) -> list[str]:
r = self.run("get", "blessed-replica-versions", "--json", full_stdout=True)
# ic-admin's get-blessed-replica-versions (alias of
# get-elected-guestos-versions) ignores --json and prints one Git
# revision per line, just like get-elected-hostos-versions.
r = self.run("get", "blessed-replica-versions", full_stdout=True)
if r.exit_code != 0:
raise AirflowException("dre exited with status code %d", r.exit_code)
return cast(list[str], json.loads(r.output)["value"]["blessed_version_ids"])
decoded = [x.strip() for x in r.output.splitlines() if x.strip()]
assert all(re.match("^[0-9a-f]{40}$", x) for x in decoded), (
"One of the returned values in %s is not a valid Git revision" % decoded
)
return cast(list[str], decoded)

def get_elected_hostos_versions(self) -> list[str]:
r = self.run("get", "elected-hostos-versions", full_stdout=True)
Expand Down
Loading