Skip to content

chore: Proposal to upgrade the XRC to release 2026.06.19#346

Merged
mbjorkqvist merged 2 commits into
mainfrom
mathias/proposal-upgrade-xrc-2026-06-19
Jun 19, 2026
Merged

chore: Proposal to upgrade the XRC to release 2026.06.19#346
mbjorkqvist merged 2 commits into
mainfrom
mathias/proposal-upgrade-xrc-2026-06-19

Conversation

@mbjorkqvist

Copy link
Copy Markdown
Contributor

Proposal to upgrade the XRC to release 2026.06.19.

@mbjorkqvist mbjorkqvist marked this pull request as ready for review June 19, 2026 13:24
@mbjorkqvist mbjorkqvist requested a review from a team as a code owner June 19, 2026 13:24
@zeropath-ai

zeropath-ai Bot commented Jun 19, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 1378940.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► deployment/mainnet/exchange_rate_canister_upgrade_2026_06_19.md
    Add proposal for exchange rate canister upgrade
    Include repository, git hash, Wasm hash, and upgrade args hash
    Specify target canister and previous proposal link
    Detail motivation for the upgrade: never cache/return empty crypto rates, only query listed pairs
    Provide release notes with git log for specific commits
    Include instructions for upgrade args and Wasm verification

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

canbench 🏋 (dir: src/xrc) e6db6fa 2026-06-19 13:39:51 UTC

src/xrc/canbench_results.yml is up to date
📦 canbench_results_benchmark.csv available in artifacts

---------------------------------------------------

Summary:
  instructions:
    status:   No significant changes 👍
    counts:   [total 9 | regressed 0 | improved 0 | new 0 | unchanged 9]
    change:   [max +201.83K | p75 +9.36K | median +2.99K | p25 +340 | min -24.95K]
    change %: [max +0.69% | p75 +0.03% | median 0.01% | p25 0.00% | min -0.23%]

  heap_increase:
    status:   No significant changes 👍
    counts:   [total 9 | regressed 0 | improved 0 | new 0 | unchanged 9]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

  stable_memory_increase:
    status:   No significant changes 👍
    counts:   [total 9 | regressed 0 | improved 0 | new 0 | unchanged 9]
    change:   [max 0 | p75 0 | median 0 | p25 0 | min 0]
    change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]

---------------------------------------------------
CSV results saved to canbench_results.csv

@gregorydemay gregorydemay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbjorkqvist !

Comment thread deployment/mainnet/exchange_rate_canister_upgrade_2026_06_19.md
Comment thread deployment/mainnet/exchange_rate_canister_upgrade_2026_06_19.md
@mbjorkqvist mbjorkqvist merged commit e9f97ba into main Jun 19, 2026
21 checks passed
@mbjorkqvist mbjorkqvist deleted the mathias/proposal-upgrade-xrc-2026-06-19 branch June 19, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants