Fix compile errors found by cargo check against ic-cdk 0.19#12
Merged
Conversation
- wallet/multi-canister factory: add missing environment_variables field to CanisterSettings - https-outcalls: add is_replicated field to HttpRequestArgs, fix HttpResponse → HttpRequestResult - multi-canister content_service: fix StableBTreeMap iter() to use entry.value() - certified-variables: fix AsHashTree import, rewrite certify_response for ic-http-certification 3.1 - evm-rpc: fix Call::with_args to take reference (&) - ckbtc: remove unused query import
JoshDFN
requested review from
derlerd-dfinity,
gregorydemay and
raymondk
as code owners
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran
cargo checkon all 11 Rust skills against ic-cdk 0.19. Found and fixed compile errors in 6 skills:environment_variables: Nonefield inCanisterSettings(new in ic-cdk 0.19)is_replicated: Nonefield inHttpRequestArgs(new in ic-cdk 0.19),HttpResponsetype renamed toHttpRequestResultStableBTreeMap::iter()returnsLazyEntryin ic-stable-structures 0.7, not tuplesHashTree→AsHashTree),certify_responserewritten for ic-http-certification 3.1 APICall::with_argstakes a reference (&), not owned valuequeryimportCompile status after fixes