Skip to content

fix(ci): don't fail e2e job when dev server already exited #4054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aterga wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

fix(ci): don't fail e2e job when dev server already exited #4054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
797db3e
fix(ci): don't fail e2e job when dev server already exited
claude Jun 22, 2026
b35ca80
Merge branch 'main' into claude/fix-e2e-dev-server-cleanup
aterga Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/canister-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,12 @@ jobs:

- name: Stop dev server
if: ${{ always() }}
run: kill ${{ steps.dev-server-start.outputs.dev_server_pid }}
# `2>/dev/null || true` so cleanup never fails an otherwise-green job:
# under `bash -e` a bare `kill` of an already-exited dev server (the
# backgrounded `npm run dev | tee` pipeline PID is often reaped before
# this step) exits non-zero and would fail the run. Anything still
# alive is reaped by the runner's orphan-process cleanup.
run: kill ${{ steps.dev-server-start.outputs.dev_server_pid }} 2>/dev/null || true

- name: Archive dev server logs
if: ${{ always() }}
Expand Down
Loading