test: cover deposit ledger-error mapper arms#157
Draft
mbjorkqvist wants to merge 3 commits into
Draft
Conversation
Adds unit tests driving each TransferFromError variant through deposit(): the two payload-carrying arms (InsufficientFunds, InsufficientAllowance) map to their typed DepositError counterparts, and the variants a well-behaved ledger should never return collapse to InternalError carrying the ledger's Display message rather than trapping. Previously only TemporarilyUnavailable was exercised. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
✅ Ready to approve
The change is test-only and correctly exercises each mapper arm with assertions aligned to the production to_ledger_error implementation.
Note: this review does not count toward required approvals for merging.
Pull request overview
Adds missing unit test coverage for deposit()’s TransferFromError -> DepositError mapping, ensuring all to_ledger_error match arms are exercised and that “unexpected” ledger errors are surfaced as InternalError strings rather than trapping.
Changes:
- Add
deposit()tests forInsufficientFundsandInsufficientAllowancemapping (including payload preservation). - Add a table-driven test covering “unexpected”
TransferFromErrorvariants mapping toLedgerTransferFromError::InternalError(format!("{e}")).
File summaries
| File | Description |
|---|---|
| canister/src/tests.rs | Adds unit tests to cover all TransferFromError variants mapped by the deposit error mapper. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
…iven test Match the codebase convention for error-path coverage (e.g. should_reject_invalid_orders_without_modifying_book): a single test with a (ledger reply, expected DepositError) cases table and one setup, rather than the previous mix of per-variant tests plus a loop. Also covers TemporarilyUnavailable so the table documents the full mapping. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
✅ Ready to approve
The change is isolated to tests and correctly exercises the full error-mapping surface described in the PR without altering production code paths.
Note: this review does not count toward required approvals for merging.
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes a test gap surfaced during the repo review: of the nine
TransferFromErrorvariants the deposit path translates into_ledger_error, onlyTemporarilyUnavailablewas exercised.Adds unit tests that drive each variant through
deposit()and assert the mapping:InsufficientFunds/InsufficientAllowancecarry their payload into the typedDepositError.BadFee,BadBurn,CreatedInFuture,Duplicate,GenericError,TooOld) collapse toInternalErrorcarrying the ledger's Display message — and notably do not trap.Test-only; no production code changed.