test(frontend): cover Solana WC unreviewed warning#13142
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recent Solana WalletConnect changes intentionally allow transactions with unreviewed instructions, but rely on the review UI to warn users that the decoded summary may be incomplete. That warning is the safety control that replaces outright rejection, so it should have regression coverage.
Changes
SolWalletConnectSignReviewcomponent coverage for theunreviewedbranch.unreviewedis true and absent by default.Risky behavior now covered: users are warned before approving Solana WalletConnect transactions that contain instructions OISY cannot decode.
Test files added/updated:
src/frontend/src/tests/sol/components/wallet-connect/SolWalletConnectSignReview.spec.ts.Why this reduces regression risk: the mapper already proves the flag is produced; this verifies the user-facing warning is actually shown in the signing review, preserving the safety signal for incomplete transaction summaries.
Tests
PATH="$HOME/.nvm/versions/node/v24.17.0/bin:$PATH" npm run test -- src/frontend/src/tests/sol/components/wallet-connect/SolWalletConnectSignReview.spec.tsPATH="$HOME/.nvm/versions/node/v24.17.0/bin:$PATH" npm run check:tests