fix(frontend): reject invalid WalletConnect signing requests#13154
Draft
cursor[bot] wants to merge 2 commits into
Draft
fix(frontend): reject invalid WalletConnect signing requests#13154cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recent WalletConnect BTC/Solana signing changes introduced concrete request lifecycle failures:
{ success: false }without sending a WalletConnect JSON-RPC rejection when the wallet address was unavailable or when a sign-and-send transaction could not produce a signature. The user flow stopped, but the dApp request stayed pending indefinitely.signPsbtcould approve a request with an unchanged PSBT whensignInputswas present but selected no usable input indices, reporting success without signing anything.Changes
signInputsis provided but resolves to no input indices, before opening the signing progress flow.signInputsPSBT path.Tests
PATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run test -- --run src/frontend/src/tests/sol/services/wallet-connect.services.spec.ts src/frontend/src/tests/btc/services/wallet-connect.services.spec.tsPATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run formatPATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run lint -- --max-warnings 0PATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run checkPATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run testPATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run lint:lockfile