fix(frontend): reject mixed Solana WC reviews#13158
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A malicious Solana WalletConnect request could include a decoded, benign-looking transfer plus an additional unreviewed instruction. The review summary displayed only the decoded movement, while approval still signed the full transaction, making hidden fund-moving effects possible.
Changes
ambiguous.Tests
npm run test -- src/frontend/src/tests/sol/utils/sol-transactions.utils.spec.ts src/frontend/src/tests/sol/services/wallet-connect.services.spec.tsnpm run formatnpm run lint -- --max-warnings 0npm run checknpm run testnpm run check:testsnpm run lint:lockfile