Skip to content

fix(frontend): flag Solana account creation recipients#13161

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/high-severity-issue-resolution-144d
Draft

fix(frontend): flag Solana account creation recipients#13161
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/high-severity-issue-resolution-144d

Conversation

@cursor

@cursor cursor Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Motivation

A Solana WalletConnect transaction could combine a SystemProgram.createAccount instruction with a later SOL transfer. The review summary summed both lamport movements, but raw CreateAccount mapping omitted the created account recipient, so the UI could show only the later transfer destination while approval still signed the full transaction.

Changes

  • Map raw Solana CreateAccount instructions with the created account as destination.
  • Reuse the existing ambiguous-transaction guard so bundled SOL movements to different recipients are rejected instead of shown as a single misleading transfer.
  • Added regression coverage for the hidden account-creation recipient scenario and updated the existing fixture expectation.

Tests

  • PATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run test -- --run src/frontend/src/tests/sol/utils/sol-instructions.utils.spec.ts src/frontend/src/tests/sol/utils/sol-transactions.utils.spec.ts
  • PATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run format
  • PATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run lint -- --max-warnings 0
  • PATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run check
  • PATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run test
  • PATH="/home/ubuntu/.nvm/versions/node/v24.17.0/bin:$PATH" npm run lint:lockfile
Open in Web View Automation 

cursoragent and others added 2 commits June 22, 2026 11:08
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
Co-authored-by: Antonio Ventilii <AntonioVentilii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant