docs(ai): add spec to close OnRamper signing oracle#13164
Draft
AntonioVentilii wants to merge 12 commits into
Draft
docs(ai): add spec to close OnRamper signing oracle#13164AntonioVentilii wants to merge 12 commits into
AntonioVentilii wants to merge 12 commits into
Conversation
…nice-pasteur-f8faf6
…nice-pasteur-f8faf6
…nice-pasteur-f8faf6
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sign_onramper_widget_urlis an open signing oracle: it HMAC-signs thewallets/network_wallets/wallet_address_tagsparameters exactly as supplied by any authenticated caller, without checking the addresses belong tomsg_caller(). An attacker could get the backend to sign their own address and phish a victim into funding it via a valid, OISY-branded OnRamper URL. The HMAC is OnRamper's sole URL-integrity check, so a valid signature reads as OISY authorization.This PR adds the spec only (spec-first per
docs/ai/spec-driven-development/workflow.md); implementation follows in a separate breaking PR.Changes
docs/ai/spec-driven-development/specs/2026-06-22-fix-onramper-signing-oracle.md.async.Tests
None — documentation only. The spec defines the test plan (derivation-parity tests per chain, oracle-closed regression tests, FE updates) for the implementation PR.