refactor(frontend): own Checkbox natively, detach from gix#13169
Draft
AntonioVentilii wants to merge 1 commit into
Draft
refactor(frontend): own Checkbox natively, detach from gix#13169AntonioVentilii wants to merge 1 commit into
AntonioVentilii wants to merge 1 commit into
Conversation
Bring the gix Checkbox in-house as a native Svelte 5 OISY component. - New $lib/components/ui/Checkbox.svelte: runes, one-way checked + onChange callback (matches gix's data flow; consumers keep owning checked), keyboard handling via the shared handleKeyPress - Fold the former gix.scss overrides (div.radio, --checkbox-padding) and the gix form-input styling into the component, using OISY design tokens - Rewire all 6 consumers off @dfinity/gix-components No new deps, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of detaching OISY from
@dfinity/gix-components(gix is now maintenance-mode). Brings theCheckboxprimitive in-house as a native, fully-owned OISY component. Same pattern as the Toggle pilot (#13165). Stacked on #13163.Changes
$lib/components/ui/Checkbox.svelte: native Svelte 5 (runes), one-waychecked+ anonChangecallback — matching gix's data flow exactly, so consumers keep owningchecked(no double-toggle).gix.scssoverrides (div.radio,--checkbox-padding) and the gix form-input styling into the component, using OISY design tokens (notheme()in scoped styles).@dfinity/gix-components.Tests
lint --max-warnings 0clean;checkclean (only the pre-existing unrelatedsol-instructions-systemerror on main)