refactor(frontend): own Collapsible + IconExpandMore natively, detach from gix#13172
Draft
AntonioVentilii wants to merge 1 commit into
Draft
refactor(frontend): own Collapsible + IconExpandMore natively, detach from gix#13172AntonioVentilii wants to merge 1 commit into
AntonioVentilii wants to merge 1 commit into
Conversation
… from gix - New $lib/components/ui/Collapsible.svelte (gix source is already Svelte 5; swapped to OISY i18n core.text.collapse/expand, native testId 'collapsible') - Vendor its deps natively: $lib/components/icons/IconExpandMore.svelte, $lib/components/ui/TestIdWrapper.svelte, $lib/types/collapsible.ts - Add core.text.collapse/expand i18n labels (regenerated i18n types) - Rewire Collapsible consumers (3) and ALL direct IconExpandMore consumers (7, incl OISY's IconExpand wrapper) off @dfinity/gix-components No new deps, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Detaching OISY from
@dfinity/gix-components(now maintenance-mode). BringsCollapsibleand itsIconExpandMoreicon in-house. Stacked on #13163.Changes
$lib/components/ui/Collapsible.svelte— gix's source is already Svelte 5; swapped to OISY i18n (core.text.collapse/expand) and a nativecollapsibletest id.$lib/components/icons/IconExpandMore.svelte,$lib/components/ui/TestIdWrapper.svelte,$lib/types/collapsible.ts.core.text.collapse/expandlabels (regenerated i18n types).IconExpandMoreconsumers (incl OISY's ownIconExpandwrapper) off gix.Tests
lint --max-warnings 0clean;checkclean (only the pre-existing unrelatedsol-instructions-systemerror)