feat: First draft of flexible http outcalls by oggy-dfin · Pull Request #5890 · dfinity/portal

oggy-dfin · 2025-06-27T14:31:58Z

Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.

If you are submitting a pull request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

Follows the developer docs style guide.
Follows the best practices and guidelines.
New documentation pages include document tags.
New documentation pages include SEO keywords.
New documents are in the .mdx file format to support the previous two components.
New documents are registered in /sidebars.js, otherwise, it will not appear in the
side navigation bar.
Make sure that the .github/CODEOWNERS file is
contains any new directories or specific documents that you added that should be reviewed by a specific teamm.

github-actions · 2025-06-27T14:32:42Z

🤖 Here's your preview: https://hada6-4yaaa-aaaam-abaha-cai.icp0.io

Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>

mraszyk

Left some more feedback.

…or flexible calls (#9001) Extends the CanisterHttpRequestContext for flexible outcalls. This is the very first step to enable [flexible HTTPS outcalls](dfinity/portal#5890).

#9090) Adds the error types for flexible outcalls according to the draft spec (dfinity/portal#5890).

…g payload for flexible outcall (#9572) Adapts the HTTP outcalls payload builder for flexible calls to filter out reject responses when trying to find a viable ok-response group. Currently, `find_flexible_responses` picks up responses from the pool via `get_response_content_by_hash`, which returns the full `CanisterHttpResponse` including `Reject` content. It doesn't filter by content type -- any response from a valid committee member gets included, whether `Success` or `Reject`. According to the [spec](dfinity/portal#5890) an `ok` result is `vec http_request_result` (status, headers, body). A `Reject` can't be meaningfully represented as an `http_request_result`. The canister called `flexible_http_request` to get HTTP responses: a node that couldn't reach the server didn't produce a useful HTTP response. The `min_responses` threshold still applies after filtering -- if too many nodes produced `Reject` and we can't reach `min_responses` successes, the group isn't included and the request will eventually time out. In a follow-up PR, to aid with debugging, we will adapt the payload builder to include `Reject` responses in the `node_details` of the [flexible_http_request_err](https://github.com/dfinity/portal/pull/5890/changes#diff-0e66a818a5739ab2c506ec15a9b9e83c5851f14d1f8416b79a130899e547d463R105) whenever a call to `flexible_http_request` times out. --------- Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>

fspreiss · 2026-03-30T08:18:30Z

+};
+
+type flexible_http_request_err = record {
+  global_error: opt variant {


I discussed with @gregorydemay that we add yet another global error tag too_many_rejects, which would occur if more than total_requests - min_responses responses from the HTTP adapters are reject responses (e.g., DNS/connection issues).

github-actions bot added the interface-spec Changes to the IC Interface Specification label Jun 27, 2025

oggy-dfin commented Jun 27, 2025

View reviewed changes

Comment thread docs/references/ic-interface-spec.md Outdated

oggy-dfin force-pushed the oggy/flexible-http-outcalls branch from 748a6ef to b40ad06 Compare September 22, 2025 12:13

oggy-dfin and others added 5 commits October 6, 2025 14:41

Describe the new cost API

fcac9b3

Add the pricing_version to the outcalls endpoint.

9ea0269

Fix text alignment etc

c8528ed

Update docs/references/ic-interface-spec.md

4ead597

Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>

Martin's comments

3b2c02d

mraszyk reviewed Oct 13, 2025

View reviewed changes

Comment thread docs/references/_attachments/ic.did Outdated

Rename request time to http roundtrip time

660280c

THLO reviewed Oct 29, 2025

View reviewed changes

Comment thread docs/references/ic-interface-spec.md

oggy-dfin added 3 commits November 12, 2025 14:17

First draft of flexible http outcalls

685be30

New version (after feature review)

e6c288d

Latest version building on top of the new pricing model PR

14a0954

oggy-dfin force-pushed the oggy/flexible-http-outcalls branch from e14bba0 to 14a0954 Compare November 12, 2025 15:04

oggy-dfin changed the title ~~First draft of flexible http outcalls~~ feat: First draft of flexible http outcalls Nov 12, 2025

Fix the ic.did types

417bbdc

oggy-dfin commented Nov 19, 2025

View reviewed changes

Comment thread docs/references/_attachments/ic.did Outdated

Improve the error reporting

0484f2c

mraszyk reviewed Nov 21, 2025

View reviewed changes

Comment thread docs/references/ic-interface-spec.md Outdated

mraszyk reviewed Nov 21, 2025

View reviewed changes

Comment thread docs/references/_attachments/ic.did Outdated

mraszyk reviewed Nov 21, 2025

View reviewed changes

Comment thread docs/references/_attachments/ic.did Outdated

mraszyk reviewed Nov 21, 2025

View reviewed changes

Comment thread docs/references/_attachments/ic.did Outdated

mraszyk reviewed Nov 21, 2025

View reviewed changes

Comment thread docs/references/ic-interface-spec.md Outdated

mraszyk reviewed Nov 21, 2025

View reviewed changes

Comment thread docs/references/_attachments/ic.did

mraszyk reviewed Nov 21, 2025

View reviewed changes

Comment thread docs/references/ic-interface-spec.md Outdated

oggy-dfin and others added 3 commits November 21, 2025 14:59

Update docs/references/ic-interface-spec.md

e0a4c11

Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>

Update docs/references/_attachments/ic.did

34e2bfa

Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>

Update docs/references/_attachments/ic.did

fa34180

Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>

better docs

44d5242

mihailjianu1 marked this pull request as ready for review January 28, 2026 09:50

mihailjianu1 requested review from a team as code owners January 28, 2026 09:50

mraszyk reviewed Jan 28, 2026

View reviewed changes

Comment thread docs/references/_attachments/ic.did Outdated

Comment thread docs/references/_attachments/ic.did Outdated

Comment thread docs/references/ic-interface-spec.md Outdated

Comment thread docs/references/ic-interface-spec.md

Comment thread docs/references/_attachments/ic.did Outdated

mihailjianu1 added 2 commits January 28, 2026 14:55

better node errors

bea49b3

advice

dd42f48

mraszyk reviewed Jan 28, 2026

View reviewed changes

Comment thread docs/references/_attachments/ic.did Outdated

mraszyk reviewed Jan 28, 2026

View reviewed changes

Comment thread docs/references/_attachments/ic.did Outdated

better err

951fdcc

mraszyk reviewed Jan 29, 2026

View reviewed changes

Comment thread docs/references/ic-interface-spec.md

mraszyk reviewed Jan 29, 2026

View reviewed changes

Comment thread docs/references/ic-interface-spec.md Outdated

mraszyk reviewed Jan 29, 2026

View reviewed changes

Comment thread docs/references/ic-interface-spec.md

mihailjianu1 marked this pull request as draft January 29, 2026 09:03

mraszyk mentioned this pull request Jan 29, 2026

New HTTP outcalls pricing model #6101

Closed

docs

3c1f3a4

fspreiss mentioned this pull request Feb 23, 2026

feat(flexible-outcalls): CON-1640 extend CanisterHttpRequestContext for flexible calls dfinity/ic#9001

Merged

fspreiss mentioned this pull request Mar 1, 2026

feat(flexible-outcalls): IC-1949 add error types for flexible outcalls dfinity/ic#9090

Merged

github-merge-queue bot pushed a commit to dfinity/ic that referenced this pull request Mar 3, 2026

feat(flexible-outcalls): IC-1949 add error types for flexible outcalls (

f64fafb

#9090) Adds the error types for flexible outcalls according to the draft spec (dfinity/portal#5890).

fspreiss reviewed Mar 26, 2026

View reviewed changes

Comment thread docs/references/_attachments/ic.did Outdated

remove invalid parameters

f12c020

fspreiss mentioned this pull request Mar 26, 2026

feat(http-outcalls): CON-1686 disregard reject responses when building payload for flexible outcall dfinity/ic#9572

Merged

fspreiss reviewed Apr 17, 2026

View reviewed changes

introduce too_many_rejects global error

defe26d

Conversation

oggy-dfin commented Jun 27, 2025 • edited by mihailjianu1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mraszyk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fspreiss Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

fspreiss Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

oggy-dfin commented Jun 27, 2025 •

edited by mihailjianu1

Loading

github-actions bot commented Jun 27, 2025 •

edited

Loading