Skip to content

chore: update replica version to 719ff387aab462ce5759c4c20c30de959fe9538c#4532

Merged
lwshang merged 4 commits into
masterfrom
lwshang/chore-update-replica-719ff387aab462ce5759c4c20c30de959fe9538c-master
Apr 22, 2026
Merged

chore: update replica version to 719ff387aab462ce5759c4c20c30de959fe9538c#4532
lwshang merged 4 commits into
masterfrom
lwshang/chore-update-replica-719ff387aab462ce5759c4c20c30de959fe9538c-master

Conversation

@lwshang

@lwshang lwshang commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updates replica to elected commit 719ff387aab462ce5759c4c20c30de959fe9538c, incorporating proposals 140089–141436
  • Fixes a build bug where non-version git tags (e.g. asset-canister-404-support) were picked as the nearest tag by get_git_hash(), producing an invalid semver string that crashed dfx start; fix uses Version::parse(tag).is_ok() to skip non-version tags

lwshang and others added 4 commits April 22, 2026 16:27
Tags like `asset-canister-404-support` were being picked as the nearest
tag, producing an invalid semver string that crashed on startup.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@lwshang lwshang marked this pull request as ready for review April 22, 2026 20:37
@lwshang lwshang requested a review from a team as a code owner April 22, 2026 20:37
@lwshang lwshang enabled auto-merge (squash) April 22, 2026 20:39
@lwshang lwshang merged commit 77ae5d6 into master Apr 22, 2026
113 checks passed
@lwshang lwshang deleted the lwshang/chore-update-replica-719ff387aab462ce5759c4c20c30de959fe9538c-master branch April 22, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants