chore: update replica version to 719ff387aab462ce5759c4c20c30de959fe9538c#4532
Merged
lwshang merged 4 commits intoApr 22, 2026
Conversation
Tags like `asset-canister-404-support` were being picked as the nearest tag, producing an invalid semver string that crashed on startup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adamspofford-dfinity
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
719ff387aab462ce5759c4c20c30de959fe9538c, incorporating proposals 140089–141436asset-canister-404-support) were picked as the nearest tag byget_git_hash(), producing an invalid semver string that crasheddfx start; fix usesVersion::parse(tag).is_ok()to skip non-version tags