Skip to content

Avoid using decimal comma on machines with different locale#282

Merged
yhabib merged 1 commit into
mainfrom
kloet/comma
Jun 15, 2026
Merged

Avoid using decimal comma on machines with different locale#282
yhabib merged 1 commit into
mainfrom
kloet/comma

Conversation

@dskloetd

Copy link
Copy Markdown
Contributor

Motivation

This error was reported:

/Users/daviddalbusco/.config/dfx/identity/snsdemo8/identity.pem transfer --amount 5001570,49997000 --fee 0,00001000 jg6qm-uw64t-m6ppo-oluwn-ogr5j-dc5pm-lgy2p-eh6px-hebcd-5v73i-nqe
error: Invalid value "5001570,49997000" for '--amount <AMOUNT>': Failed to parse tokens as unsigned integer

which seems to happen because a awk output a decimal comma instead of a decimal point.

This PR might fix it for the line where the error happened but I'm not sure (actually I would expect it) if there are other places that would have the same problem.

@dskloetd dskloetd changed the title Avoid using decimal comma on mahcines with different locale Avoid using decimal comma on machines with different locale Nov 27, 2023
@yhabib yhabib marked this pull request as ready for review June 15, 2026 12:33
@yhabib yhabib requested a review from a team as a code owner June 15, 2026 12:33

@yhabib yhabib left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yhabib yhabib merged commit a15c9d3 into main Jun 15, 2026
18 checks passed
@yhabib yhabib deleted the kloet/comma branch June 15, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants