fix(ckbtc): use key_1 ecdsa key name for dfx 0.32.0#605
Merged
Conversation
dfx 0.32.0 renamed the local threshold-ECDSA test key from dfx_test_key to key_1. The ckBTC minter was still deployed with ecdsa_key_name = "dfx_test_key", so get_btc_address trapped on ecdsa_public_key with ChainKeyError: Requested unknown threshold key ecdsa:Secp256k1:dfx_test_key. Closes #604
bjoernek
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dfx 0.32.0 renamed the local threshold-ECDSA test key from
dfx_test_keytokey_1. The ckBTC minter is still deployed withecdsa_key_name = "dfx_test_key", soget_btc_addresstraps onecdsa_public_keywithChainKeyError: Requested unknown threshold key ecdsa:Secp256k1:dfx_test_key. This breaks downstream consumers minting test ckBTC against the snapshot and blocks the nns-dapp dfx 0.32.0 bump (dfinity/nns-dapp#7903).Changes
ecdsa_key_namefromdfx_test_keytokey_1to match the key dfx 0.32.0 provides.Closes #604