Skip to content

Reactive Draw Tool State - #1593

Merged
Nick (ingalls) merged 3 commits into
mainfrom
reactive-draw-tools
Jul 23, 2026
Merged

Reactive Draw Tool State#1593
Nick (ingalls) merged 3 commits into
mainfrom
reactive-draw-tools

Conversation

@ingalls

@ingalls Nick (ingalls) commented Jul 17, 2026

Copy link
Copy Markdown
Member

Context

  • 🐛 Ensure draw modes are reactive for consistent Draw Tools popup
  • 🚀 Update iOS XCode version on new CloudTAK release

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/web/src/stores/modules/draw.ts 0.00% 15 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ingalls Nick (ingalls) changed the title clear Reactive Draw Tool State Jul 17, 2026
Copilot AI review requested due to automatic review settings July 23, 2026 22:52
@ingalls Nick (ingalls) self-assigned this Jul 23, 2026
@ingalls Nick (ingalls) added build-deploy Build process and deployment web-frontend-map Issues affecting the Vue.js web interface web-frontend Container for all web frontend issues labels Jul 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes DrawTool UI-consumed state reactive even though the DrawTool instance itself is stored with markRaw() in the map store, ensuring Vue templates/watchers update correctly.

Changes:

  • Converted mode, editing, _changeCount, and snappingOptions into Vue refs with getters/setters to preserve a public API while enabling reactivity.
  • Wrapped route in shallowReactive and point/lasso in reactive so template bindings (e.g., v-model) update as expected.
  • Updated canFinish and TerraDraw change handling to correctly track the ref-based _changeCount.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 23, 2026 22:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

@ingalls
Nick (ingalls) merged commit 687384a into main Jul 23, 2026
15 of 16 checks passed
@ingalls
Nick (ingalls) deleted the reactive-draw-tools branch July 23, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-deploy Build process and deployment web-frontend Container for all web frontend issues web-frontend-map Issues affecting the Vue.js web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants