Fix kubectl-in-curlimages/curl: use DNS name instead of command substitution - #397
Draft
dgkanatsios with Copilot wants to merge 2 commits into
Draft
Fix kubectl-in-curlimages/curl: use DNS name instead of command substitution#397dgkanatsios with Copilot wants to merge 2 commits into
dgkanatsios with Copilot wants to merge 2 commits into
Conversation
…l inside curlimages/curl pod
Copilot
AI
changed the title
[WIP] Fix the code according to review comment
Fix kubectl-in-curlimages/curl: use DNS name instead of command substitution
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curlimages/curldoesn't shipkubectl, so$(kubectl get svc my-app-svc -o jsonpath="{.spec.clusterIP}")inside that pod silently fails. The canary exercise also needs to run the curl from inside the cluster since ClusterIP isn't reachable from the host.Changes
c.pod_design.md: Replace the broken host-shellwhile/curl/kubectl get svcpattern with a self-contained throwaway pod that curls the service by DNS name:Using the in-cluster DNS name (
my-app-svc) eliminates the need forkubectlinside the pod entirely.