fix: [DHIS2-20985] Username field selects first suggestion instead of clicked user#4493
Open
fix: [DHIS2-20985] Username field selects first suggestion instead of clicked user#4493
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
🚀 Deployed on https://deploy-preview-4493.capture.netlify.dhis2.org |
|
simonadomnisoru
approved these changes
Mar 26, 2026
geethaalwan
approved these changes
Apr 9, 2026
geethaalwan
left a comment
geethaalwan
left a comment
There was a problem hiding this comment.
Tested successfully on 2.44,2.43.1,2.42.5,2.41.9,2.40.12 versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DHIS2-20985
The UserField component has a search input with a suggestions dropdown. When focus leaves both the input and the suggestions, onExitSearch() is called to close the dropdown. This blur detection previously relied on checking getAttribute('name') on
<div>elements, which is non-standard and fails when event.relatedTarget is a child element (e.g. inside ) that doesn't carry the name attribute.This PR makes two fixes:
Some existing bugs for long values are also been improved: