Skip to content

chore: [DHIS2-21184] Remove orphaned Cypress step definitions#4499

Open
henrikmv wants to merge 14 commits intomasterfrom
hv/chore/DHIS2-21184_CypressCleanup
Open

chore: [DHIS2-21184] Remove orphaned Cypress step definitions#4499
henrikmv wants to merge 14 commits intomasterfrom
hv/chore/DHIS2-21184_CypressCleanup

Conversation

@henrikmv
Copy link
Copy Markdown
Contributor

@henrikmv henrikmv commented Mar 23, 2026

DHIS2-21184

Summary

Removes Cypress step definitions (Given/When/Then) from JS files that are no longer referenced by any .feature file. Each orphaned definition was verified by searching all feature files for matching step text, accounting for regex patterns and Cucumber optional groups.

Files changed

File Removals
ProgramStageSelector.js 1 step (the stage-button should be disabled)
HiddenProgramStage.js Entire file deleted (feature file is fully commented out)
EnrollmentPage/sharedSteps.js 1 step (you are on the enrollment dashboard)
EnrollmentEditEventPageForm.js 1 step (regex: the user changes the gender to)
NewPage.js 3 steps
ScopeSelector.js 1 step (you should be taken to the main page with only program selected)
SearchPage.js 12 steps
WidgetEnrollment/index.js 3 steps (regex-based, including marked for follow up)
WidgetsForEnrollmentAddEventPage.js 1 step (regex-based)
TrackerBulkActions.js 1 step
TrackerWorkingListsDev.js 1 step
TrackerWorkingListsUser.js 2 steps
EventWorkingListsDev.js Multiple steps
EventWorkingListsUser.js Multiple steps

No production code or .feature files were modified.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

devin-ai-integration bot and others added 11 commits March 23, 2026 16:10
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
devin-ai-integration bot and others added 2 commits March 23, 2026 16:34
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
Co-Authored-By: henrik.vadet@dhis2.org <henrik@devOtta.no>
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

@henrikmv henrikmv added testing and removed testing labels Mar 23, 2026
@henrikmv henrikmv marked this pull request as ready for review March 25, 2026 15:25
@henrikmv henrikmv requested a review from a team as a code owner March 25, 2026 15:25
Copy link
Copy Markdown
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged after the hard-freeze period is over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants