fix: disable focus trap in drawer content [DHIS2-21063]#842
Open
fix: disable focus trap in drawer content [DHIS2-21063]#842
Conversation
Sharmyn28
changed the title
|
tomzemp
approved these changes
Mar 25, 2026
Member
tomzemp
left a comment
tomzemp
left a comment
There was a problem hiding this comment.
This looks like it will solve the immediate issues, but I wonder if it would be possible to trap focus within the icon modal itself? I guess there's a bit of a disadvantage of turning off the trapped focus for the drawer as you can then focus throughout the screen (not just the modal, but the other elements as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix search bar icon selector for Option set (option) and Program Stages
DHIS2-21063
Option set
Program stage
