Open
Conversation
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adds support for listing Analytics Table Hooks in the app, including view configuration, schema/mocks, and standard list-page tests.
Changes:
- Introduces a new
analyticsTableHooksList page wired into the existing lazy-route mechanism. - Adds a Zod list schema + test builder support for generating mock analytics table hook items.
- Registers list view column configuration and adds translations for newly surfaced fields.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/testUtils/builders.ts | Adds testAnalyticsTableHook builder using the new list schema for list tests. |
| src/pages/analyticsTableHooks/List.tsx | Implements the List route component via DefaultSectionList. |
| src/pages/analyticsTableHooks/List.spec.tsx | Adds default list test suite for the new section using schema + builder. |
| src/pages/analyticsTableHooks/form/index.ts | Exposes the analytics table hook list schema for reuse. |
| src/pages/analyticsTableHooks/form/analyticsTableHookSchema.ts | Defines the Zod schema for analytics table hook list items (incl. enums + default list columns). |
| src/lib/sectionList/listViews/sectionListViewsConfig.ts | Registers analyticsTableHook list column configuration (default + additional available columns). |
| src/lib/constants/translatedModelProperties.ts | Adds translations for analyticsTableType, phase, resourceTableType, and sql. |
| src/mocks/schema/analyticsTableHooksSchema.json | Adds mocked schema JSON used by list tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DHIS2-21176