Skip to content

Raise minimum libsqlite3-sys to 0.24.0 - #5108

Open
LucaCappelletti94 wants to merge 1 commit into
diesel-rs:mainfrom
LucaCappelletti94:libsqlite3-sys-bump
Open

Raise minimum libsqlite3-sys to 0.24.0#5108
LucaCappelletti94 wants to merge 1 commit into
diesel-rs:mainfrom
LucaCappelletti94:libsqlite3-sys-bump

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Member

Prerequisite for wrapping sqlite3_autovacuum_pages, mentioned by @weiznich in a comment in PR #5098. That function was added in SQLite 3.37.0 (2021-11) and is absent from the bundled amalgamation of every libsqlite3-sys older than 0.24.0 (the first release to ship SQLite 3.38.0). Bumping the floor here lets the follow-up on_autovacuum PR use the ffi:: alias like every other hook wrapper in the crate.

@weiznich weiznich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear that's not possible to change as changing the minimal supported libsqlite3-sys version is a public visible change due to the status of libsqlite3-sys being a sys crate and only one version of a sys crate could exist in a single dependency tree. So a hypothetical uses could have pinned libsqlite3-sys to 0.17.2 and that would break to build with this version bump. So this would require a major version bump, which we don't have planned yet.

I think it's fine to just not have sqlite3_autovacuum_pages support then.

@LucaCappelletti94

LucaCappelletti94 commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

Ok, then sqlite3_autovacuum_pages gets parked until some future date when we decide to bump libsqlite3. Maybe we should register this among the "things that may get unlocked upon a major version bump"?

@weiznich

Copy link
Copy Markdown
Member

Yes that would be meaningful. I've already put a few TODO: diesel 3.0 comments in the source code for similar minor things. Might be meaningful to have that for this function as well.

@LucaCappelletti94

Copy link
Copy Markdown
Member Author

It would be nice if there was a way to specify "future PR" or some such in GitHub, maybe the next best thing could be a tag for the PR?

@weiznich weiznich added the Diesel 3.0 Issues to be fixed with a possible diesel 3.0 release as a fix would require a breaking change label Jul 10, 2026
@weiznich

Copy link
Copy Markdown
Member

I can tag it with the Diesel 3.0 label we have. Hopefully it doesn't get lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Diesel 3.0 Issues to be fixed with a possible diesel 3.0 release as a fix would require a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants