Allow diesel_dynamic_schema runtime columns in GROUP BY/ HAVING - #5165
Open
LucaCappelletti94 wants to merge 2 commits into
Open
Allow diesel_dynamic_schema runtime columns in GROUP BY/ HAVING#5165LucaCappelletti94 wants to merge 2 commits into
diesel_dynamic_schema runtime columns in GROUP BY/ HAVING#5165LucaCappelletti94 wants to merge 2 commits into
Conversation
LucaCappelletti94
marked this pull request as ready for review
August 26, 2026 11:39
LucaCappelletti94
force-pushed
the
dynamic-schema-grouping
branch
from
August 28, 2026 07:42
a675ece to
fcef975
Compare
LucaCappelletti94
force-pushed
the
dynamic-schema-grouping
branch
from
August 28, 2026 10:11
fcef975 to
4531e12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diesel_dynamic_schemaruntime columns only implementedValidGrouping<()>, so.group_by(col)and.having(pred)could not work. This adds a blanketValidGrouping<GB>forColumnso both clauses work, including grouping by a tuple of runtime columns.The associated type is
is_aggregate::Neveras a runtime column cannot be checked for membership in theGROUP BY.I am unsure whether there was any reason for the lack of support, or this was just a missing feature.