Support PostgreSQL numeric infinities in PgNumeric - #5168
Open
LucaCappelletti94 wants to merge 1 commit into
Open
Support PostgreSQL numeric infinities in PgNumeric#5168LucaCappelletti94 wants to merge 1 commit into
PostgreSQL numeric infinities in PgNumeric#5168LucaCappelletti94 wants to merge 1 commit into
Conversation
LucaCappelletti94
marked this pull request as ready for review
August 27, 2026 10:08
LucaCappelletti94
force-pushed
the
postgres-numeric-infinity
branch
from
August 28, 2026 07:42
8076347 to
f314c12
Compare
LucaCappelletti94
force-pushed
the
postgres-numeric-infinity
branch
from
August 28, 2026 10:11
f314c12 to
8b55406
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQLacceptsInfinityand-Infinityfor unconstrained numeric, but Diesel rejects their binary sign words during decoding withInvalidNumericSign. Diesel also cannot bind those values today, becausePgNumerichas no public value that represents either infinity.This patch adds explicit
PgNumericvariants for both infinity values, usingPostgreSQL's wire sign words0xD000and0xF000.BigDecimalremains finite-only, so reading either infinity asBigDecimalstill returns an error, matching its existingNaNbehavior.This is, to my understanding, API breaking, but the only variant I could come up with is a second full-domain enum, for example
PgNumericWithInfinities, maybe wrappingPgNumeric.