Add integration tests for SQLite json -> and ->> operators - #5169
Open
zaveshaa wants to merge 3 commits into
Open
Add integration tests for SQLite json -> and ->> operators#5169zaveshaa wants to merge 3 commits into
zaveshaa wants to merge 3 commits into
Conversation
Member
|
Thanks for opening this PR. Could you explain the motivation to add these tests? For me it looks like that this behaviour is already tested by the doc-tests, so the tests look rather duplicated to me? |
Author
|
Good point. The doc-tests cover the basic behaviour of That said, if you think the doc-tests already cover this well enough, I'm fine dropping the PR — no point adding redundant tests. Let me know which way you'd rather go. |
zaveshaa
force-pushed
the
add-sqlite-json-arrow-operator-tests
branch
from
August 29, 2026 16:42
4b416fa to
2fed431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #4366 asked for integration coverage of the SQLite json
->and->>operators. The operators exist but only doc-tests cover them.These integration tests add:
->(retrieve_as_object_sqlite) with a JSON path and an integer index, onJsonandJsonb->>(retrieve_as_text) with a JSON path and an array index, plus the NULL case for a missing pathRelates to #4366.