Support negative MySQL and MariaDB TIME values - #5170
Open
LucaCappelletti94 wants to merge 2 commits into
Open
Conversation
Member
Author
|
Filed Alorel/rust-indexed-db#85 uphill so that the audit CI failure may be fixed, but I see that the last commit in that repo was last year. We'll see. |
LucaCappelletti94
marked this pull request as ready for review
August 27, 2026 18:33
LucaCappelletti94
force-pushed
the
mysql-negative-time
branch
2 times, most recently
from
August 28, 2026 10:11
85c3920 to
51e1355
Compare
LucaCappelletti94
force-pushed
the
mysql-negative-time
branch
from
September 2, 2026 15:57
51e1355 to
6de9415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQLandMariaDBuseTIMEfor signed durations, but Diesel rejects every negativeMYSQL_TIMEbeforeMysqlTimeor custom decoders can inspect it.This PR only adds support to the sign only for SQL Time, while
chrono::NaiveTimeandtime::Timecontinue to return a deserialization error because neither type can represent a signed duration. NegativeDate,Datetime, andTimestampvalues remain rejected at the raw-value boundary.For this PR I use GPT Sol.