6.9.0 release latest#1338
Conversation
MancunianSam
commented
May 20, 2025
MancunianSam
commented
- Release 6.9.0
- Only run gpg signing on release
- Profile wrangling
- Update branch name
techncl
left a comment
techncl
left a comment
There was a problem hiding this comment.
Looks good! Just some minor comments.
| def fetch_merged_prs(): | ||
| url = f"{API_BASE}/repos/{REPO}/pulls" | ||
| params = {"state": "closed", "base": "develop", "per_page": 100} | ||
| r = requests.get(url, headers=HEADERS, params=params) |
|
|
||
| def get_release(): | ||
| url = f"{API_BASE}/repos/{REPO}/releases/tags/{RELEASE_TAG}" | ||
| r = requests.get(url, headers=HEADERS) |
|
|
||
| update_release_notes(release_id, body) | ||
|
|
||
| print("📦 Deleting existing assets...") |
There was a problem hiding this comment.
Maybe the bin emoji that you used earlier/a bin emoji might be better than the box one?
| asset_ids = [a["id"] for a in release.get("assets", [])] | ||
| delete_assets(asset_ids) | ||
|
|
||
| print("📦 Uploading new assets...") |
There was a problem hiding this comment.
Maybe the up arrow emoji that you used earlier/a bin emoji might be better than the box one?
|
|
||
| print("📦 Uploading new assets...") | ||
| windows_jar = next(Path("droid-binary/target").glob("*win64-with-jre.zip")) | ||
| generic_jar = next(Path("droid-binary/target").glob("*bin.zip")) |
There was a problem hiding this comment.
Maybe a print here that lets us know that the Windows jar is uploading, like print("Uploading Windows Jar...")
| print("📦 Uploading new assets...") | ||
| windows_jar = next(Path("droid-binary/target").glob("*win64-with-jre.zip")) | ||
| generic_jar = next(Path("droid-binary/target").glob("*bin.zip")) | ||
| upload_asset(upload_url, windows_jar) |
There was a problem hiding this comment.
Maybe a print here that lets us know that the generic jar is uploading, like print("Uploading Generic Jar...")
| sys.exit(1) | ||
|
|
||
| if len(sys.argv) != 2: | ||
| print("Usage: python create_github_release_raw.py <release_version>") |
There was a problem hiding this comment.
Is there a clearer error message we could prepend to this? Like "Error - Expected 2 arguments..."
There was a problem hiding this comment.
This is fairly standard if you mess up a CLI tool. You get how you were supposed to do it. I'll leave it.
| @@ -1,3 +1,15 @@ | |||
| Version 6.9.0 | |||
| #1166 Improvement: Add JSON output | |||
There was a problem hiding this comment.
These change items are missing a * in front of them like the others
3 participants
