Add support for vue-router v5#20
Closed
djscruggs wants to merge 1 commit into
Closed
Conversation
Widen the vue-router peer dependency range to "^4.0.15 || ^5.0.0" so consumers may use vue-router v5. v5 is a non-breaking release that merges unplugin-vue-router into core; bedrock-vue uses only stable router APIs (addRoute, currentRoute.value, beforeEach) via augmentRouter, so no source changes are required. Existing v4 consumers remain supported. Addresses #18. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
Closing — already fixed by another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for
vue-routerv5 by widening the peer dependency range. Closes #18.Per the v5.0.0 release notes, v5 is a non-breaking release that merges
unplugin-vue-routerinto the core package. The only breaking change is the IIFE build dropping bundled@vue/devtools-api, which bedrock-vue does not use.vue-routeris a peer dependency only — there are novue-routerimports inlib/orcomponents/. The router is created by the consuming app and passed intoaugmentRouter({app, router}), which uses only stable, unchanged APIs (addRoute,currentRoute.value,beforeEach). No source changes are required.Changes
package.json: peer dep widened to^4.0.15 || ^5.0.0; version bumped5.1.1-0→5.2.0.CHANGELOG.md: new5.2.0entry.README.md: note that both v4 and v5 are supported.Widening (rather than replacing) keeps existing v4 consumers working, so this is a backward-compatible minor release.
Verification
npm installsucceeds with the widened range.npm run lintpasses (the only CI check).🤖 Generated with Claude Code