added byoip support for load balancer and nat-gateway - #1873
Merged
DO-rrao merged 4 commits intoJul 30, 2026
Merged
Conversation
rbhatia-code
marked this pull request as ready for review
July 23, 2026 22:36
DO-rrao
reviewed
Jul 24, 2026
| @@ -104,6 +104,8 @@ With the load-balancer command, you can list, create, or delete load balancers, | |||
| AddStringFlag(cmdLoadBalancerCreate, doctl.ArgLoadBalancerNetworkStack, "", "", "The network stack type determines the allocation of ipv4/ipv6 addresses to the load balancer, e.g.: `IPV4` or `DUALSTACK`"+ | |||
| " (NOTE: this feature is in private preview, contact DigitalOcean support to review its public availability.)") | |||
Contributor
There was a problem hiding this comment.
nit: Small inconsistency between the two new bits: the NAT gateway path guards with if ip != "" while the LB path just does r.IP = ip unconditionally. Both are correct today (the field is omitempty), but if someone ever wires --ip into the LB update command down the line, that unconditional assignment would quietly start sending ip on updates, which the API treats as create-only. A if ip != "" guard (or a one-line comment noting it's create-only) would make that intent obvious and future-proof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.