agents: resolve ${VAR} env references in --spec manifests locally - #1898
Merged
SSharma-10 merged 1 commit intoJul 31, 2026
Conversation
adilhafeez
marked this pull request as ready for review
July 30, 2026 22:54
SSharma-10
merged commit Jul 31, 2026
ca00ee4
into
digitalocean:feat/agents-subcommands
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doctl agents start --spec(andagents triggers create/update --spec) now resolve${VAR}references in the manifest from the local environment before uploading, so specs likeOPENAI_API_KEY: ${OPENAI_API_KEY}work instead of shipping the literal string into the sandbox.${NAME}expands; bare$VAR,$(...), and other shell-isms embedded in manifests (skills instructions, prompts) pass through untouched.$${VAR}escapes to a literal${VAR}.agents startand the trigger--specflags documents the behavior, including that fresh-trigger manifests are stored expanded server-side.Based on #1853 (
feat/agents-subcommands), which this PR targets as its base.Test plan
TestExpandManifestEnvtable tests: set/empty/unset variables, missing-name error de-dup,$${VAR}escape, bare-dollar passthroughTestReadManifest/expands_env_referencesintegration casego test ./commands/passes (except pre-existing keychain-dependentTestRegistryLogin/TestRegistryLogoutfailures, unrelated)go vet ./commands/cleanMade with Cursor