Support annotations errors#2
Open
margori wants to merge 7 commits into
Open
Conversation
dignajar
reviewed
Apr 19, 2022
Contributor
Author
|
Refactor implemented. Reduced complexity in methods and added exception catches for wrong annotations inside methods |
celliso1
suggested changes
Mar 8, 2025
| # start-replicas | ||
| startReplicas = 1 | ||
| startReplicasAnnotation = 'another-autoscaler/start-replicas' | ||
| if startReplicasAnnotation not in deployAnnotations: |
There was a problem hiding this comment.
startReplicas has a default value 1; if startReplicasAnnotation not in deployAnnotations we should use the default and continue processing, not return.
| # stop-replicas | ||
| stopReplicas = 0 | ||
| stopReplicasAnnotation = 'another-autoscaler/stop-replicas' | ||
| if stopReplicasAnnotation not in deployAnnotations: |
There was a problem hiding this comment.
stopReplicas has a default value 0; if stopReplicasAnnotation not in deployAnnotations we should use the default and continue processing, not return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is an error in an annotation, service stops completely.