CI, tests, and Stories architecture refactor - #1
Merged
Conversation
Introduce GitHub Actions with SwiftLint and iOS simulator tests, pre-commit hooks, StoriesProgressModel with TimelineView progress, StoriesVideoManager, ViewModel split, stable session group order for navigation, and StoriesKitTests coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Use modern Task.sleep API, drop unused pattern binding, and isolate video manager access on MainActor in player observer closures. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-tests.sh,run-swiftlint.sh,install-git-hooks.sh)StoriesKitTestswith coverage for ViewModel navigation, group sorting, video manager, and view-state mappingStoriesProgressModel+TimelineViewprogress bar,StoriesVideoManager, split ViewModel into focused extensions, extract progress bar views andStoriesViewStateMappersessionGroupIDs) so next/previous stays correct after pages are marked viewedStoriesFactoryTest plan
./Scripts/run-swiftlint.sh lint— 0 violations./Scripts/run-tests.sh— 25 tests pass