Support multi line separator - #130
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 67.70% 69.11% +1.40%
==========================================
Files 48 45 -3
Lines 703 654 -49
Branches 213 195 -18
==========================================
- Hits 476 452 -24
+ Misses 99 95 -4
+ Partials 128 107 -21 ☔ View full report in Codecov by Sentry. |
|
I don't think we need to cover this generated class with tests. |
6932cf0 to
d6e30ce
Compare
|
@dirkgroot , what do you think about this change? |
|
@goto1134 I'm sorry for the delay. Unfortunately I currently don't have a lot of time available to review your PR. I'll try to take at look at this sometime in the upcoming 2 weeks. |
to visually distinguish them from tokens and states
…e in line
According to structurizr dsl parser, the script ends once a line with a single rbrace ('}') is met.
See https://github.com/structurizr/java/blob/39bf3d0890afc4caa52cf3302269a12fc2a4236b/structurizr-dsl/src/main/java/com/structurizr/dsl/StructurizrDslParser.java#L208
d6e30ce to
ef00d65
Compare
|
@dirkgroot , I rebased it to the master to make sure it is still working. Could you please take a look? |
|
Hi @goto1134, thanks for this contribution! I've been testing this, and I discovered that this change does not yet play well with the auto formatter. This code: Results in the following code, after auto formatting: As you can see, the |
|
@dirkgroot do you think it's necessary to keep the line breaks after reformating, or should we drop them? |
Fixes #110