Skip to content

Support multi line separator - #130

Open
goto1134 wants to merge 16 commits into
dirkgroot:mainfrom
goto1134:support-line-continuations
Open

Support multi line separator#130
goto1134 wants to merge 16 commits into
dirkgroot:mainfrom
goto1134:support-line-continuations

Conversation

@goto1134

@goto1134 goto1134 commented Apr 1, 2024

Copy link
Copy Markdown

Fixes #110

@goto1134 goto1134 changed the title Support line continuations Support multi line separator Apr 1, 2024
@codecov

codecov Bot commented Apr 4, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.11%. Comparing base (9980790) to head (d6e30ce).
Report is 35 commits behind head on main.

Files Patch % Lines
...structurizr/dsl/psi/impl/SDAnimationBlockImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   67.70%   69.11%   +1.40%     
==========================================
  Files          48       45       -3     
  Lines         703      654      -49     
  Branches      213      195      -18     
==========================================
- Hits          476      452      -24     
+ Misses         99       95       -4     
+ Partials      128      107      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goto1134

goto1134 commented Apr 6, 2024

Copy link
Copy Markdown
Author

I don't think we need to cover this generated class with tests.

@goto1134
goto1134 force-pushed the support-line-continuations branch from 6932cf0 to d6e30ce Compare April 8, 2024 11:44
@goto1134

Copy link
Copy Markdown
Author

@dirkgroot , what do you think about this change?

@dirkgroot

Copy link
Copy Markdown
Owner

@goto1134 I'm sorry for the delay. Unfortunately I currently don't have a lot of time available to review your PR. I'll try to take at look at this sometime in the upcoming 2 weeks.

@goto1134
goto1134 force-pushed the support-line-continuations branch from d6e30ce to ef00d65 Compare March 4, 2025 13:09
@goto1134

goto1134 commented Mar 4, 2025

Copy link
Copy Markdown
Author

@dirkgroot , I rebased it to the master to make sure it is still working. Could you please take a look?

@dirkgroot

dirkgroot commented Apr 4, 2025

Copy link
Copy Markdown
Owner

Hi @goto1134, thanks for this contribution! I've been testing this, and I discovered that this change does not yet play well with the auto formatter.

This code:

workspace test {
    model {
        softwareSystem "System" \
            "Description"
    }
}

Results in the following code, after auto formatting:

workspace test {
    model {
        softwareSystem "System"
        "Description"
    }
}

As you can see, the \ is deleted and the "Description" string is not properly indented anymore.

@goto1134

Copy link
Copy Markdown
Author

@dirkgroot do you think it's necessary to keep the line breaks after reformating, or should we drop them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parser error when inserting a manual newline with character \

2 participants