Fix audio issues with multiple users in the channel (#3251)#3256
Merged
quinchs merged 1 commit intodiscord-net:devfrom Mar 22, 2026
Merged
Conversation
Add check for empty payload before commit Incorporated patch from #3523 for multi-user voice session
quinchs
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current library crashes with
NullReferenceExceptionwhen processing a commit with an empty payload.When commit fails it goes to the it allocates empty
DaveAllocatedSpanand callskeyPackage.ToMemory()what led toNullReferenceExceptionafter several calls.This patch adds check for empty payload and process it without commiting changes, preventing the crash.
Changes
Related Issues
Tests
Changes was tested locally via my own bot. It worked reliably. Changes from #3253 did not help me to fix the issue with multiple voice users