DEV: Add backward compatibility for tag object arrays - #47
Merged
Conversation
tgxworld
force-pushed
the
fix-tag-object-compatibility
branch
4 times, most recently
from
January 16, 2026 05:55
ba35ede to
627dade
Compare
ZogStriP
approved these changes
Jan 16, 2026
What is the problem? Discourse core PR #36678 changes `renderTag` to pass tag objects instead of strings to custom tag renderers. This breaks the `iconTagRenderer` function which expects the `tag` parameter to be a string and calls `escapeExpression(tag)` directly. What is the solution? Extract the tag name at the start of `iconTagRenderer` using `typeof tag === "string" ? tag : tag.name` before processing. Also rename the local `tagName` variable to `htmlTagName` to avoid confusion with the extracted tag name. This ensures backward compatibility with both the old string format and the new object format.
tgxworld
force-pushed
the
fix-tag-object-compatibility
branch
from
January 19, 2026 05:33
627dade to
69a4b41
Compare
gormus
added a commit
to gormus/discourse-tag-icons
that referenced
this pull request
Jan 25, 2026
commit 75d7f1d Author: Alan Guo Xiang Tan <gxtan1990@gmail.com> Date: Mon Jan 19 13:45:11 2026 +0800 DEV: Add backward compatibility for tag object arrays (discourse#47) What is the problem? Discourse core PR #36678 changes `renderTag` to pass tag objects instead of strings to custom tag renderers. This breaks the `iconTagRenderer` function which expects the `tag` parameter to be a string and calls `escapeExpression(tag)` directly. What is the solution? Extract the tag name at the start of `iconTagRenderer` using `typeof tag === "string" ? tag : tag.name` before processing. Also rename the local `tagName` variable to `htmlTagName` to avoid confusion with the extracted tag name. This ensures backward compatibility with both the old string format and the new object format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem?
Discourse core PR #36678 changes
renderTagto pass tag objectsinstead of strings to custom tag renderers. This breaks the
iconTagRendererfunction which expects thetagparameter to bea string and calls
escapeExpression(tag)directly.What is the solution?
Extract the tag name at the start of
iconTagRendererusingtypeof tag === "string" ? tag : tag.namebefore processing.Also rename the local
tagNamevariable tohtmlTagNameto avoidconfusion with the extracted tag name. This ensures backward
compatibility with both the old string format and the new object format.