DEV: Add backwards-compatible tag object handling - #50
Merged
Conversation
What is the problem?
Discourse core PR #36678 changes tags from strings to objects
with `{ id, name, slug }` format. The `iconTagRenderer` function
in this theme calls `tag.toLowerCase()` which fails when `tag`
is an object instead of a string.
What is the solution?
Extract the tag name using the same pattern as core's `defaultRenderTag`:
`const tagName = typeof tag === "string" ? tag : tag.name`
This maintains backwards compatibility with Discourse versions before
the change.
discourse/discourse#36678
tgxworld
force-pushed
the
fix/tag-object-compatibility
branch
from
January 29, 2026 03:35
30155a5 to
4ea9e2f
Compare
nattsw
approved these changes
Jan 29, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem?
Discourse core PR #36678 changes tags from strings to objects
with
{ id, name, slug }format. TheiconTagRendererfunctionin this theme calls
tag.toLowerCase()which fails whentagis an object instead of a string.
What is the solution?
Extract the tag name using the same pattern as core's
defaultRenderTag:const tagName = typeof tag === "string" ? tag : tag.nameThis maintains backwards compatibility with Discourse versions before
the change.
discourse/discourse#36678