Skip to content

DEV: remove unneeded test assertation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awesomerobot merged 1 commit into from
Jul 23, 2026
Merged

DEV: remove unneeded test assertation #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions test/acceptance/tag-icons-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ acceptance("Topic with tags", function (needs) {

const topicResponse = topicFixtures["/t/280/1.json"];
topicResponse.tags = ["tag1", "Tag2", "newsman"];
topicResponse.tags_descriptions = {
newsman: "newsman <a href='test'>link</a>",
};

test("Decorate topic title", async function (assert) {
await visit("/t/internationalization-localization/280");
Expand Down Expand Up @@ -41,14 +38,6 @@ acceptance("Topic with tags", function (needs) {
assert
.dom(".discourse-tags a.discourse-tag .tag-icon .d-icon")
.hasClass("d-icon-gear", "tag matches correct icon");

assert
.dom(".discourse-tag[data-tag-name='newsman']")
.hasAttribute(
"title",
"newsman link",
"has correct title without markup"
);
});

test("Tag uppercase matches", async function (assert) {
Expand Down