DEV: Match tag icons on the name the viewer reads - #66
Open
ZogStriP wants to merge 1 commit into
Open
Conversation
The page object located tags through `data-tag-name`, which core is changing to carry the untranslated name so it stays stable across locales. Asserting on the visible text instead holds either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TagIconpage object located tags through.discourse-tag[data-tag-name=...]. discourse/discourse#42869 changes that attribute to carry the tag's untranslated name so it stays stable across locales, which breaks the localized specs here — they passサポート, and the attribute will readsupport.The icon itself renders correctly either way; only the locator was stale. Matching on the visible text plus
:has(.tag-icon ...)asserts what the reader actually sees and is independent of which name the attribute carries.Verified green against core
mainand against the core PR branch, so this can merge in either order.