Numerous mapping fixes#22
Conversation
In the recommended implementation, items will either have an abstract OR a description. Theses, for example, have only an abstract, no description. Without this modification, thesis abstracts are not available to OAI-PMH.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughFIELD_MAPPING gains ChangesOAI Metadata Mapping Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/Plugin/OaiMetadataMap/DgiStandard.php`:
- Line 126: The commit message must be updated to accurately reflect that three
relator mappings were added (not just 'cur' and 'ths'); update the commit
summary/body to mention that 'relators:cur', 'relators:ths' and 'relators:hst'
(host) were added, referencing the change in DgiStandard.php where the mapping
'relators:hst' => 'dcterms:contributor' was introduced so the commit message
matches the code changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6f1fd959-e3ce-4d81-89ad-8a9b9764594a
📒 Files selected for processing (1)
src/Plugin/OaiMetadataMap/DgiStandard.php
| 'relators:dpc' => 'dcterms:contributor', | ||
| 'relators:drt' => 'dcterms:contributor', | ||
| 'relators:edt' => 'dcterms:contributor', | ||
| 'relators:hst' => 'dcterms:contributor', |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
MARC Code List for Relators hst host
💡 Result:
In the MARC Code List for Relators, the code hst corresponds to the term host [1][2]. A host is defined as a performer who contributes to a resource by leading a program (often broadcast) that includes other guests, performers, etc., such as a talk show host [2]. The Library of Congress maintains this list, and the codes and terms are used to designate the relationship between an agent and a resource in bibliographic records [3][4]. These codes can also be accessed via the Library of Congress Linked Data Service at id.loc.gov/vocabulary/relators [3][4].
Citations:
- 1: https://www.loc.gov/marc/relators/relacode.html
- 2: https://www.loc.gov/marc/relators/relaterm.html
- 3: https://www.loc.gov/marc/relators/
- 4: https://www.loc.gov/marc/relators
🏁 Script executed:
#!/bin/bash
# Description: Search for references to the 'hst' relator code in the codebase.
# Search for 'hst' relator usage in field configurations, migrations, or data
rg -i "relators?:hst\b|relator.*\bhst\b|'hst'|\"hst\"" -g '!*.php' -C2Repository: discoverygarden/dgi_standard_oai
Length of output: 58
Update commit message to include 'hst' relator mapping.
The commit message mentions adding only 'cur' and 'ths' relator mappings, but the code also adds 'hst' (host, a performer who leads a program). Update the commit message to accurately reflect all three additions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/Plugin/OaiMetadataMap/DgiStandard.php` at line 126, The commit message
must be updated to accurately reflect that three relator mappings were added
(not just 'cur' and 'ths'); update the commit summary/body to mention that
'relators:cur', 'relators:ths' and 'relators:hst' (host) were added, referencing
the change in DgiStandard.php where the mapping 'relators:hst' =>
'dcterms:contributor' was introduced so the commit message matches the code
changes.
Add presenter, artist, and designer to list of mappings
Maps field_publication_title and field_publication_number to dcterms:source
bondjimbond
changed the title
travisLilleberg
left a comment
travisLilleberg
left a comment
There was a problem hiding this comment.
The metadata additions are all valid according to dcterms and MARC relator specifications.
Approved. The only consideration I can think of is if there are any other sites using this that don't want their abstract or publication fields in the OAI feed, but that seems very unlikely.
|
Tag generated by PR: v1.5.2 |
3 participants
In the recommended implementation, items will either have an abstract OR a description. Theses, for example, have only an abstract, no description.
Without this modification, thesis abstracts are not available to OAI-PMH.
Subsequent updates add the publication title and number to
dcterms:source, which was entirely missing from the mapping but is a field provided for in the dplava schema: https://dplava.lib.virginia.edu/dplava.xsd; as well as mapping additional Relator terms to thedc:contributoranddc:creatorelements.Summary by CodeRabbit